Commit dcaac3f7 authored Sep 04, 2019 by Raul E Rangel Committed by Ulf Hansson Nov 13, 2019

mmc: sdhci: Check card status after reset

In sdhci_do_reset we call the reset callback which is typically
sdhci_reset. sdhci_reset can wait for up to 100ms waiting for the
controller to reset. If SDHCI_RESET_ALL was passed as the flag, the
controller will clear the IRQ mask. If during that 100ms the card is
removed there is no notification to the MMC system that the card was
removed. So from the drivers point of view the card is always present.

By making sdhci_reinit compare the present state it can schedule a
rescan if the card was removed while a reset was in progress.

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 31f4f5b4

drivers/mmc/host/sdhci.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -337,8 +337,19 @@ static void sdhci_init(struct sdhci_host *host, int soft)

		static void sdhci_reinit(struct sdhci_host *host)
		{
		u32 cd = host->ier & (SDHCI_INT_CARD_REMOVE \| SDHCI_INT_CARD_INSERT);

		sdhci_init(host, 0);
		sdhci_enable_card_detection(host);

		/*
		* A change to the card detect bits indicates a change in present state,
		* refer sdhci_set_card_detection(). A card detect interrupt might have
		* been missed while the host controller was being reset, so trigger a
		* rescan to check.
		*/
		if (cd != (host->ier & (SDHCI_INT_CARD_REMOVE \| SDHCI_INT_CARD_INSERT)))
		mmc_detect_change(host->mmc, msecs_to_jiffies(200));
		}

		static void __sdhci_led_activate(struct sdhci_host *host)

Admin message