Commit dc8b73eb authored by Daniel Wagner's avatar Daniel Wagner Committed by Guenter Roeck
Browse files

hwmon: (adt7470) No need for additional synchronization on kthread_stop() 



The kthread_stop() waits for the thread to exit. There is no need for an
additional synchronization needed to join on the kthread.

The completion was added by 89fac11c ("adt7470: make automatic fan
control really work").

Signed-off-by: default avatarDaniel Wagner <daniel.wagner@bmw-carit.de>
Cc: Darrick J. Wong <djwong@us.ibm.com>
Cc: Jean Delvare <jdelvare@suse.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 0a8784e7

drivers/hwmon/adt7470.c

+0 −4
Original line number Diff line number Diff line
@@ -177,7 +177,6 @@ struct adt7470_data { 
	u8			pwm_auto_temp[ADT7470_PWM_COUNT];



	struct task_struct	*auto_update;

	struct completion	auto_update_stop;

	unsigned int		auto_update_interval;

};
@@ -281,7 +280,6 @@ static int adt7470_update_thread(void *p) 
		schedule_timeout(msecs_to_jiffies(data->auto_update_interval));

	}



	complete_all(&data->auto_update_stop);

	return 0;

}
@@ -1356,7 +1354,6 @@ static int adt7470_probe(struct i2c_client *client, 
	if (IS_ERR(hwmon_dev))

		return PTR_ERR(hwmon_dev);



	init_completion(&data->auto_update_stop);

	data->auto_update = kthread_run(adt7470_update_thread, client, "%s",

					dev_name(hwmon_dev));

	if (IS_ERR(data->auto_update)) {
@@ -1371,7 +1368,6 @@ static int adt7470_remove(struct i2c_client *client) 
	struct adt7470_data *data = i2c_get_clientdata(client);



	kthread_stop(data->auto_update);

	wait_for_completion(&data->auto_update_stop);

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE