Commit dc8b4afc authored Feb 27, 2016 by Manuel Lauss Committed by Tejun Heo Feb 29, 2016

ata: ahci: don't mark HotPlugCapable Ports as external/removable



The HPCP bit is set by bioses for on-board sata ports either because
they think sata is hotplug capable in general or to allow Windows
to display a "device eject" icon on ports which are routed to an
external connector bracket.

However in Redhat Bugzilla #1310682, users report that with kernel 4.4,
where this bit test first appeared, a lot of partitions on sata drives
are now mounted automatically.

This patch should fix redhat and a lot of other distros which
unconditionally automount all devices which have the "removable"
bit set.

Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 8a3e33cf ("ata: ahci: find eSATA ports and flag them as removable" changes userspace behavior)
Link: http://lkml.kernel.org/g/56CF35FA.1070500@redhat.com
Cc: stable@vger.kernel.org #v4.4+

parent d243bed3

drivers/ata/libahci.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1168,8 +1168,7 @@ static void ahci_port_init(struct device dev, struct ata_port ap,

		/* mark esata ports */
		tmp = readl(port_mmio + PORT_CMD);
		if ((tmp & PORT_CMD_HPCP) \|\|
		((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS)))
		if ((tmp & PORT_CMD_ESP) && (hpriv->cap & HOST_CAP_SXS))
		ap->pflags \|= ATA_PFLAG_EXTERNAL;
		}

Admin message