Commit dc87a98d authored by Robin Murphy's avatar Robin Murphy Committed by Will Deacon
Browse files

iommu/arm-smmu: Fall back to global bypass 



Unlike SMMUv2, SMMUv3 has no easy way to bypass unknown stream IDs,
other than allocating and filling in the entire stream table with bypass
entries, which for some configurations would waste *gigabytes* of RAM.
Otherwise, all transactions on unknown stream IDs will simply be aborted
with a C_BAD_STREAMID event.

Rather than render the system unusable in the case of an invalid DT,
avoid enabling the SMMU altogether such that everything bypasses
(though letting the explicit disable_bypass option take precedence).

Signed-off-by: default avatarRobin Murphy <robin.murphy@arm.com>
Signed-off-by: default avatarWill Deacon <will.deacon@arm.com>
parent b9bc8811

drivers/iommu/arm-smmu-v3.c

+44 −4
Original line number Diff line number Diff line
@@ -123,6 +123,10 @@ 
#define CR2_RECINVSID			(1 << 1)

#define CR2_E2H				(1 << 0)



#define ARM_SMMU_GBPA			0x44

#define GBPA_ABORT			(1 << 20)

#define GBPA_UPDATE			(1 << 31)



#define ARM_SMMU_IRQ_CTRL		0x50

#define IRQ_CTRL_EVTQ_IRQEN		(1 << 2)

#define IRQ_CTRL_PRIQ_IRQEN		(1 << 1)
@@ -2124,6 +2128,24 @@ static int arm_smmu_write_reg_sync(struct arm_smmu_device *smmu, u32 val, 
					  1, ARM_SMMU_POLL_TIMEOUT_US);

}



/* GBPA is "special" */

static int arm_smmu_update_gbpa(struct arm_smmu_device *smmu, u32 set, u32 clr)

{

	int ret;

	u32 reg, __iomem *gbpa = smmu->base + ARM_SMMU_GBPA;



	ret = readl_relaxed_poll_timeout(gbpa, reg, !(reg & GBPA_UPDATE),

					 1, ARM_SMMU_POLL_TIMEOUT_US);

	if (ret)

		return ret;



	reg &= ~clr;

	reg |= set;

	writel_relaxed(reg | GBPA_UPDATE, gbpa);

	return readl_relaxed_poll_timeout(gbpa, reg, !(reg & GBPA_UPDATE),

					  1, ARM_SMMU_POLL_TIMEOUT_US);

}



static void arm_smmu_free_msis(void *data)

{

	struct device *dev = data;
@@ -2269,7 +2291,7 @@ static int arm_smmu_device_disable(struct arm_smmu_device *smmu) 
	return ret;

}



static int arm_smmu_device_reset(struct arm_smmu_device *smmu)

static int arm_smmu_device_reset(struct arm_smmu_device *smmu, bool bypass)

{

	int ret;

	u32 reg, enables;
@@ -2370,8 +2392,17 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu) 
		return ret;

	}



	/* Enable the SMMU interface */



	/* Enable the SMMU interface, or ensure bypass */

	if (!bypass || disable_bypass) {

		enables |= CR0_SMMUEN;

	} else {

		ret = arm_smmu_update_gbpa(smmu, 0, GBPA_ABORT);

		if (ret) {

			dev_err(smmu->dev, "GBPA not responding to update\n");

			return ret;

		}

	}

	ret = arm_smmu_write_reg_sync(smmu, enables, ARM_SMMU_CR0,

				      ARM_SMMU_CR0ACK);

	if (ret) {
@@ -2570,6 +2601,15 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev) 
	struct resource *res;

	struct arm_smmu_device *smmu;

	struct device *dev = &pdev->dev;

	bool bypass = true;

	u32 cells;



	if (of_property_read_u32(dev->of_node, "#iommu-cells", &cells))

		dev_err(dev, "missing #iommu-cells property\n");

	else if (cells != 1)

		dev_err(dev, "invalid #iommu-cells value (%d)\n", cells);

	else

		bypass = false;



	smmu = devm_kzalloc(dev, sizeof(*smmu), GFP_KERNEL);

	if (!smmu) {
@@ -2622,7 +2662,7 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev) 
	platform_set_drvdata(pdev, smmu);



	/* Reset the device */

	return arm_smmu_device_reset(smmu);

	return arm_smmu_device_reset(smmu, bypass);

}



static int arm_smmu_device_remove(struct platform_device *pdev)

CRA Git | Maintained and supported by SUSTech CRA and CCSE