mfd: arizona: Disable interrupts during resume (dc781d0e) · Commits · 戴 / test

Runtime power management does not function during system suspend but the Arizona devices need to use runtime power management to power up the device in order to handle interrupts. Try to avoid interrupts firing during resume by disabling the primary IRQ before interrupts are reenabled on resume and only reenabling it again during main resume. The goal is to avoid issues in the situation where an interrupt is asserted during resume (eg, due to it being the wake source) and the interrupt handling gets scheduled prior to the device being able to handle runtime PM. Signed-off-by:

Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:

Samuel Ortiz <sameo@linux.intel.com>

drivers/mfd/arizona-core.c

+26 −0

Original line number	Diff line number	Diff line
		@@ -263,10 +263,36 @@ static int arizona_runtime_suspend(struct device *dev)
		}
		#endif

		#ifdef CONFIG_PM_SLEEP
		static int arizona_resume_noirq(struct device *dev)
		{
		struct arizona *arizona = dev_get_drvdata(dev);

		dev_dbg(arizona->dev, "Early resume, disabling IRQ\n");
		disable_irq(arizona->irq);

		return 0;
		}

		static int arizona_resume(struct device *dev)
		{
		struct arizona *arizona = dev_get_drvdata(dev);

		dev_dbg(arizona->dev, "Late resume, reenabling IRQ\n");
		enable_irq(arizona->irq);

		return 0;
		}
		#endif

		const struct dev_pm_ops arizona_pm_ops = {
		SET_RUNTIME_PM_OPS(arizona_runtime_suspend,
		arizona_runtime_resume,
		NULL)
		SET_SYSTEM_SLEEP_PM_OPS(NULL, arizona_resume)
		#ifdef CONFIG_PM_SLEEP
		.resume_noirq = arizona_resume_noirq,
		#endif
		};
		EXPORT_SYMBOL_GPL(arizona_pm_ops);

Admin message