Commit dc6f6c97 authored Jun 04, 2014 by Oleg Nesterov Committed by Linus Torvalds Jun 04, 2014

memcg: kill start_kernel()->mm_init_owner(&init_mm)



Remove start_kernel()->mm_init_owner(&init_mm, &init_task).

This doesn't really hurt but unnecessary and misleading.  init_task is the
"swapper" thread == current, its ->mm is always NULL.  And init_mm can
only be used as ->active_mm, not as ->mm.

mm_init_owner() has a single caller with this patch, perhaps it should
die.  mm_init() can initialize ->owner under #ifdef.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Michal Hocko <mhocko@suse.cz>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Peter Chiang <pchiang@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 39af1765

init/main.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -507,7 +507,6 @@ asmlinkage __visible void __init start_kernel(void)
		page_address_init();
		pr_notice("%s", linux_banner);
		setup_arch(&command_line);
		mm_init_owner(&init_mm, &init_task);
		mm_init_cpumask(&init_mm);
		setup_command_line(command_line);
		setup_nr_cpu_ids();

Admin message