Commit dc64cc7c authored by Moshe Shemesh's avatar Moshe Shemesh Committed by Jakub Kicinski
Browse files

devlink: Add devlink reload limit option 



Add reload limit to demand restrictions on reload actions.
Reload limits supported:
no_reset: No reset allowed, no down time allowed, no link flap and no
          configuration is lost.

By default reload limit is unspecified and so no constraints on reload
actions are required.

Some combinations of action and limit are invalid. For example, driver
can not reinitialize its entities without any downtime.

The no_reset reload limit will have usecase in this patchset to
implement restricted fw_activate on mlx5.

Have the uapi parameter of reload limit ready for future support of
multiselection.

Signed-off-by: default avatarMoshe Shemesh <moshe@mellanox.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ccdf0721

drivers/net/ethernet/mellanox/mlx4/main.c

+3 −1
Original line number Diff line number Diff line
@@ -3947,6 +3947,7 @@ static int mlx4_restart_one_up(struct pci_dev *pdev, bool reload, 


static int mlx4_devlink_reload_down(struct devlink *devlink, bool netns_change,

				    enum devlink_reload_action action,

				    enum devlink_reload_limit limit,

				    struct netlink_ext_ack *extack)

{

	struct mlx4_priv *priv = devlink_priv(devlink);
@@ -3964,7 +3965,8 @@ static int mlx4_devlink_reload_down(struct devlink *devlink, bool netns_change, 
}



static int mlx4_devlink_reload_up(struct devlink *devlink, enum devlink_reload_action action,

				  u32 *actions_performed, struct netlink_ext_ack *extack)

				  enum devlink_reload_limit limit, u32 *actions_performed,

				  struct netlink_ext_ack *extack)

{

	struct mlx4_priv *priv = devlink_priv(devlink);

	struct mlx4_dev *dev = &priv->dev;

drivers/net/ethernet/mellanox/mlx5/core/devlink.c

+3 −1
Original line number Diff line number Diff line
@@ -86,6 +86,7 @@ mlx5_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req, 


static int mlx5_devlink_reload_down(struct devlink *devlink, bool netns_change,

				    enum devlink_reload_action action,

				    enum devlink_reload_limit limit,

				    struct netlink_ext_ack *extack)

{

	struct mlx5_core_dev *dev = devlink_priv(devlink);
@@ -95,7 +96,8 @@ static int mlx5_devlink_reload_down(struct devlink *devlink, bool netns_change, 
}



static int mlx5_devlink_reload_up(struct devlink *devlink, enum devlink_reload_action action,

				  u32 *actions_performed, struct netlink_ext_ack *extack)

				  enum devlink_reload_limit limit, u32 *actions_performed,

				  struct netlink_ext_ack *extack)

{

	struct mlx5_core_dev *dev = devlink_priv(devlink);

drivers/net/ethernet/mellanox/mlxsw/core.c

+3 −1
Original line number Diff line number Diff line
@@ -1415,6 +1415,7 @@ mlxsw_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req, 
static int

mlxsw_devlink_core_bus_device_reload_down(struct devlink *devlink,

					  bool netns_change, enum devlink_reload_action action,

					  enum devlink_reload_limit limit,

					  struct netlink_ext_ack *extack)

{

	struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
@@ -1428,7 +1429,8 @@ mlxsw_devlink_core_bus_device_reload_down(struct devlink *devlink, 


static int

mlxsw_devlink_core_bus_device_reload_up(struct devlink *devlink, enum devlink_reload_action action,

					u32 *actions_performed,	struct netlink_ext_ack *extack)

					enum devlink_reload_limit limit, u32 *actions_performed,

					struct netlink_ext_ack *extack)

{

	struct mlxsw_core *mlxsw_core = devlink_priv(devlink);

drivers/net/netdevsim/dev.c

+4 −2
Original line number Diff line number Diff line
@@ -701,7 +701,8 @@ static int nsim_dev_reload_create(struct nsim_dev *nsim_dev, 
static void nsim_dev_reload_destroy(struct nsim_dev *nsim_dev);



static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change,

				enum devlink_reload_action action, struct netlink_ext_ack *extack)

				enum devlink_reload_action action, enum devlink_reload_limit limit,

				struct netlink_ext_ack *extack)

{

	struct nsim_dev *nsim_dev = devlink_priv(devlink);
@@ -718,7 +719,8 @@ static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change, 
}



static int nsim_dev_reload_up(struct devlink *devlink, enum devlink_reload_action action,

			      u32 *actions_performed, struct netlink_ext_ack *extack)

			      enum devlink_reload_limit limit, u32 *actions_performed,

			      struct netlink_ext_ack *extack)

{

	struct nsim_dev *nsim_dev = devlink_priv(devlink);

include/net/devlink.h

+6 −2
Original line number Diff line number Diff line
@@ -1151,10 +1151,14 @@ struct devlink_ops { 
	 */

	u32 supported_flash_update_params;

	unsigned long reload_actions;

	unsigned long reload_limits;

	int (*reload_down)(struct devlink *devlink, bool netns_change,

			   enum devlink_reload_action action, struct netlink_ext_ack *extack);

			   enum devlink_reload_action action,

			   enum devlink_reload_limit limit,

			   struct netlink_ext_ack *extack);

	int (*reload_up)(struct devlink *devlink, enum devlink_reload_action action,

			 u32 *actions_performed, struct netlink_ext_ack *extack);

			 enum devlink_reload_limit limit, u32 *actions_performed,

			 struct netlink_ext_ack *extack);

	int (*port_type_set)(struct devlink_port *devlink_port,

			     enum devlink_port_type port_type);

	int (*port_split)(struct devlink *devlink, unsigned int port_index,

CRA Git | Maintained and supported by SUSTech CRA and CCSE