MIPS: kexec: Mark CPU offline before disabling local IRQ (dc57aaf9) · Commits · 戴 / test

After changing CPU online status, it will not be sent any IPIs such as in __flush_cache_all() on software coherency systems. Do this before disabling local IRQ. Signed-off-by:

Dengcheng Zhu <dzhu@wavecomp.com> Signed-off-by:

Paul Burton <paul.burton@mips.com> Patchwork: https://patchwork.linux-mips.org/patch/20571/ Cc: pburton@wavecomp.com Cc: ralf@linux-mips.org Cc: linux-mips@linux-mips.org Cc: rachel.mozes@intel.com

arch/mips/kernel/crash.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -36,6 +36,9 @@ static void crash_shutdown_secondary(void *passed_regs)
		if (!cpu_online(cpu))
		return;

		/* We won't be sent IPIs any more. */
		set_cpu_online(cpu, false);

		local_irq_disable();
		if (!cpumask_test_cpu(cpu, &cpus_in_crash))
		crash_save_cpu(regs, cpu);

arch/mips/kernel/machine_kexec.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -118,6 +118,9 @@ machine_kexec(struct kimage *image)
		ptr = (unsigned long) phys_to_virt(ptr);
		}

		/* Mark offline BEFORE disabling local irq. */
		set_cpu_online(smp_processor_id(), false);

		/*
		* we do not want to be bothered.
		*/

Admin message