Commit dc433797 authored Jan 09, 2020 by Xiaochen Shen Committed by Borislav Petkov Jan 13, 2020

x86/resctrl: Do not reconfigure exiting tasks



When writing a pid to file "tasks", a callback function move_myself() is
queued to this task to be called when the task returns from kernel mode
or exits. The purpose of move_myself() is to activate the newly assigned
closid and/or rmid associated with this task. This activation is done by
calling resctrl_sched_in() from move_myself(), the same function that is
called when switching to this task.

If this work is successfully queued but then the task enters PF_EXITING
status (e.g., receiving signal SIGKILL, SIGTERM) prior to the
execution of the callback move_myself(), move_myself() still calls
resctrl_sched_in() since the task status is not currently considered.

When a task is exiting, the data structure of the task itself will
be freed soon. Calling resctrl_sched_in() to write the register that
controls the task's resources is unnecessary and it implies extra
performance overhead.

Add check on task status in move_myself() and return immediately if the
task is PF_EXITING.

 [ bp: Massage. ]

Signed-off-by: Xiaochen Shen <xiaochen.shen@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Link: https://lkml.kernel.org/r/1578500026-21152-1-git-send-email-xiaochen.shen@intel.com

parent b3a987b0

arch/x86/kernel/cpu/resctrl/rdtgroup.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -532,11 +532,15 @@ static void move_myself(struct callback_head *head)
		kfree(rdtgrp);
		}

		if (unlikely(current->flags & PF_EXITING))
		goto out;

		preempt_disable();
		/* update PQR_ASSOC MSR to make resource group go into effect */
		resctrl_sched_in();
		preempt_enable();

		out:
		kfree(callback);
		}

Admin message