Commit dc205a8d authored Jun 28, 2019 by Santosh Shilimkar

rds: avoid version downgrade to legitimate newer peer connections



Connections with legitimate tos values can get into usual connection
race. It can result in consumer reject. We don't want tos value or
protocol version to be demoted for such connections otherwise
piers would end up different tos values which can results in
no connection. Example a peer initiated connection with say
tos 8 while usual connection racing can get downgraded to tos 0
which is not desirable.

Patch fixes above issue introduced by commit
commit d021fabf ("rds: rdma: add consumer reject")

Reported-by: Yanjun Zhu <yanjun.zhu@oracle.com>
Tested-by: Yanjun Zhu <yanjun.zhu@oracle.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

parent fc640d4c

net/rds/rdma_transport.c

+4 −2

Original line number	Original line	Diff line number	Diff line
	@@ -117,8 +117,10 @@ static int rds_rdma_cm_event_handler_cmn(struct rdma_cm_id *cm_id,
	((*err) <= RDS_RDMA_REJ_INCOMPAT))) {		((*err) <= RDS_RDMA_REJ_INCOMPAT))) {
	pr_warn("RDS/RDMA: conn <%pI6c, %pI6c> rejected, dropping connection\n",		pr_warn("RDS/RDMA: conn <%pI6c, %pI6c> rejected, dropping connection\n",
	&conn->c_laddr, &conn->c_faddr);		&conn->c_laddr, &conn->c_faddr);

			if (!conn->c_tos)
	conn->c_proposed_version = RDS_PROTOCOL_COMPAT_VERSION;		conn->c_proposed_version = RDS_PROTOCOL_COMPAT_VERSION;
	conn->c_tos = 0;
	rds_conn_drop(conn);		rds_conn_drop(conn);
	}		}
	rdsdebug("Connection rejected: %s\n",		rdsdebug("Connection rejected: %s\n",

Admin message