Commit dc1a3e8e authored Aug 18, 2019 by Wenwen Wang Committed by Mike Snitzer Aug 21, 2019

dm raid: add missing cleanup in raid_ctr()



If rs_prepare_reshape() fails, no cleanup is executed, leading to
leak of the raid_set structure allocated at the beginning of
raid_ctr(). To fix this issue, go to the label 'bad' if the error
occurs.

Fixes: 11e47232 ("dm raid: stop keeping raid set frozen altogether")
Cc: stable@vger.kernel.org
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent e0702d90

drivers/md/dm-raid.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3194,7 +3194,7 @@ static int raid_ctr(struct dm_target ti, unsigned int argc, char *argv)
		*/
		r = rs_prepare_reshape(rs);
		if (r)
		return r;
		goto bad;

		/* Reshaping ain't recovery, so disable recovery */
		rs_setup_recovery(rs, MaxSector);

Admin message