fs/reiserfs/journal.c: change return type of dirty_one_transaction (dc0dde61) · Commits · 戴 / test

Change return type of dirty_one_transaction from int to void. As this function always return success. Fixes below issue reported by coccicheck: fs/reiserfs/journal.c:1690:5-8: Unneeded variable: "ret". Return "0" on line 1719 Link: http://lkml.kernel.org/r/20190702175430.GA5882@hari-Inspiron-1545 Signed-off-by:

Hariprasad Kelam <hariprasad.kelam@gmail.com> Reviewed-by:

Jan Kara <jack@suse.cz> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Bharath Vedartham <linux.bhar@gmail.com> Cc: Hariprasad Kelam <hariprasad.kelam@gmail.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

fs/reiserfs/journal.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -94,7 +94,7 @@ static int journal_join(struct reiserfs_transaction_handle *th,
		struct super_block *sb);
		static void release_journal_dev(struct super_block *super,
		struct reiserfs_journal *journal);
		static int dirty_one_transaction(struct super_block *s,
		static void dirty_one_transaction(struct super_block *s,
		struct reiserfs_journal_list *jl);
		static void flush_async_commits(struct work_struct *work);
		static void queue_log_writer(struct super_block *s);
		@@ -1682,12 +1682,11 @@ next:
		}

		/* used by flush_commit_list */
		static int dirty_one_transaction(struct super_block *s,
		static void dirty_one_transaction(struct super_block *s,
		struct reiserfs_journal_list *jl)
		{
		struct reiserfs_journal_cnode *cn;
		struct reiserfs_journal_list *pjl;
		int ret = 0;

		jl->j_state \|= LIST_DIRTY;
		cn = jl->j_realblock;
		@@ -1716,7 +1715,6 @@ static int dirty_one_transaction(struct super_block *s,
		}
		cn = cn->next;
		}
		return ret;
		}

		static int kupdate_transactions(struct super_block *s,

Admin message