Commit dbfa497a authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

net: igc: let core reject the unsupported coalescing parameters 



Set ethtool_ops->supported_coalesce_params to let
the core reject unsupported coalescing parameters.

This driver was rejecting almost all unsupported
parameters already, it was only missing a check
for tx_max_coalesced_frames_irq.

As a side effect of these changes the error code for
unsupported params changes from ENOTSUPP to EOPNOTSUPP.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3ff8000d

drivers/net/ethernet/intel/igc/igc_ethtool.c

+1 −21
Original line number Diff line number Diff line
@@ -861,27 +861,6 @@ static int igc_set_coalesce(struct net_device *netdev, 
	struct igc_adapter *adapter = netdev_priv(netdev);

	int i;



	if (ec->rx_max_coalesced_frames ||

	    ec->rx_coalesce_usecs_irq ||

	    ec->rx_max_coalesced_frames_irq ||

	    ec->tx_max_coalesced_frames ||

	    ec->tx_coalesce_usecs_irq ||

	    ec->stats_block_coalesce_usecs ||

	    ec->use_adaptive_rx_coalesce ||

	    ec->use_adaptive_tx_coalesce ||

	    ec->pkt_rate_low ||

	    ec->rx_coalesce_usecs_low ||

	    ec->rx_max_coalesced_frames_low ||

	    ec->tx_coalesce_usecs_low ||

	    ec->tx_max_coalesced_frames_low ||

	    ec->pkt_rate_high ||

	    ec->rx_coalesce_usecs_high ||

	    ec->rx_max_coalesced_frames_high ||

	    ec->tx_coalesce_usecs_high ||

	    ec->tx_max_coalesced_frames_high ||

	    ec->rate_sample_interval)

		return -ENOTSUPP;



	if (ec->rx_coalesce_usecs > IGC_MAX_ITR_USECS ||

	    (ec->rx_coalesce_usecs > 3 &&

	     ec->rx_coalesce_usecs < IGC_MIN_ITR_USECS) ||
@@ -1915,6 +1894,7 @@ static int igc_set_link_ksettings(struct net_device *netdev, 
}



static const struct ethtool_ops igc_ethtool_ops = {

	.supported_coalesce_params = ETHTOOL_COALESCE_USECS,

	.get_drvinfo		= igc_get_drvinfo,

	.get_regs_len		= igc_get_regs_len,

	.get_regs		= igc_get_regs,

CRA Git | Maintained and supported by SUSTech CRA and CCSE