PCI: altera: Remove redundant platform_get_resource() return value check (dbeb4bd8) · Commits · 戴 / test

devm_ioremap_resource() fails gracefully when given a NULL resource pointer, so we don't need to check separately for failure from platform_get_resource_byname(). Remove the redundant check. Signed-off-by:

Bjorn Helgaas <bhelgaas@google.com>

drivers/pci/host/pcie-altera.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -74,7 +74,7 @@

		struct altera_pcie {
		struct platform_device *pdev;
		void __iomem *cra_base;
		void __iomem cra_base; / DT Cra */
		int irq;
		u8 root_bus_nr;
		struct irq_domain *irq_domain;
		@@ -555,11 +555,6 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie)
		struct resource *cra;

		cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra");
		if (!cra) {
		dev_err(dev, "no Cra memory resource defined\n");
		return -ENODEV;
		}

		pcie->cra_base = devm_ioremap_resource(dev, cra);
		if (IS_ERR(pcie->cra_base)) {
		dev_err(dev, "failed to map cra memory\n");

Admin message