Commit dbe7faa4 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

inet: inet_twsk_deschedule factorization 



inet_twsk_deschedule() calls are followed by inet_twsk_put().

Only particular case is in inet_twsk_purge() but there is no point
to defer the inet_twsk_put() after re-enabling BH.

Lets rename inet_twsk_deschedule() to inet_twsk_deschedule_put()
and move the inet_twsk_put() inside.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fc01538f

include/net/inet_timewait_sock.h

+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ void __inet_twsk_hashdance(struct inet_timewait_sock *tw, struct sock *sk, 
			   struct inet_hashinfo *hashinfo);



void inet_twsk_schedule(struct inet_timewait_sock *tw, const int timeo);

void inet_twsk_deschedule(struct inet_timewait_sock *tw);

void inet_twsk_deschedule_put(struct inet_timewait_sock *tw);



void inet_twsk_purge(struct inet_hashinfo *hashinfo,

		     struct inet_timewait_death_row *twdr, int family);

net/ipv4/inet_hashtables.c

+3 −6
Original line number Diff line number Diff line
@@ -380,8 +380,7 @@ static int __inet_check_established(struct inet_timewait_death_row *death_row, 
		*twp = tw;

	} else if (tw) {

		/* Silly. Should hash-dance instead... */

		inet_twsk_deschedule(tw);

		inet_twsk_put(tw);

		inet_twsk_deschedule_put(tw);

	}

	return 0;
@@ -558,10 +557,8 @@ ok: 
			inet_twsk_bind_unhash(tw, hinfo);

		spin_unlock(&head->lock);



		if (tw) {

			inet_twsk_deschedule(tw);

			inet_twsk_put(tw);

		}

		if (tw)

			inet_twsk_deschedule_put(tw);



		ret = 0;

		goto out;

net/ipv4/inet_timewait_sock.c

+8 −5
Original line number Diff line number Diff line
@@ -205,13 +205,17 @@ EXPORT_SYMBOL_GPL(inet_twsk_alloc); 
 * tcp_input.c to verify this.

 */



/* This is for handling early-kills of TIME_WAIT sockets. */

void inet_twsk_deschedule(struct inet_timewait_sock *tw)

/* This is for handling early-kills of TIME_WAIT sockets.

 * Warning : consume reference.

 * Caller should not access tw anymore.

 */

void inet_twsk_deschedule_put(struct inet_timewait_sock *tw)

{

	if (del_timer_sync(&tw->tw_timer))

		inet_twsk_kill(tw);

	inet_twsk_put(tw);

}

EXPORT_SYMBOL(inet_twsk_deschedule);

EXPORT_SYMBOL(inet_twsk_deschedule_put);



void inet_twsk_schedule(struct inet_timewait_sock *tw, const int timeo)

{
@@ -281,9 +285,8 @@ restart: 


			rcu_read_unlock();

			local_bh_disable();

			inet_twsk_deschedule(tw);

			inet_twsk_deschedule_put(tw);

			local_bh_enable();

			inet_twsk_put(tw);

			goto restart_rcu;

		}

		/* If the nulls value we got at the end of this lookup is

net/ipv4/tcp_ipv4.c

+1 −2
Original line number Diff line number Diff line
@@ -1683,8 +1683,7 @@ do_time_wait: 
							iph->daddr, th->dest,

							inet_iif(skb));

		if (sk2) {

			inet_twsk_deschedule(inet_twsk(sk));

			inet_twsk_put(inet_twsk(sk));

			inet_twsk_deschedule_put(inet_twsk(sk));

			sk = sk2;

			goto process;

		}

net/ipv4/tcp_minisocks.c

+2 −4
Original line number Diff line number Diff line
@@ -147,8 +147,7 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb, 
		if (!th->fin ||

		    TCP_SKB_CB(skb)->end_seq != tcptw->tw_rcv_nxt + 1) {

kill_with_rst:

			inet_twsk_deschedule(tw);

			inet_twsk_put(tw);

			inet_twsk_deschedule_put(tw);

			return TCP_TW_RST;

		}
@@ -198,8 +197,7 @@ kill_with_rst: 
			 */

			if (sysctl_tcp_rfc1337 == 0) {

kill:

				inet_twsk_deschedule(tw);

				inet_twsk_put(tw);

				inet_twsk_deschedule_put(tw);

				return TCP_TW_SUCCESS;

			}

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE