Commit dbda161b authored Apr 29, 2013 by Sachin Kamat Committed by Linus Torvalds Apr 29, 2013

drivers/rtc/rtc-tps65910.c: fix incorrect return value on error



'ret' was not initialized to correct error value before returning.
Since 'irq' is also being tested for 0, we cannot return irq itself as
it means function is success even though we are returning before
completing the probe.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: Chiwoong Byun <woong.byun@samsung.com>
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com>
Cc: Laxman dewangan <ldewangan@nvidia.com>
Cc: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent ad3f3cf4

drivers/rtc/rtc-tps65910.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -263,7 +263,7 @@ static int tps65910_rtc_probe(struct platform_device *pdev)
		if (irq <= 0) {
		dev_warn(&pdev->dev, "Wake up is not possible as irq = %d\n",
		irq);
		return ret;
		return -ENXIO;
		}

		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,

Admin message