ipv4: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment (dbd3393c) · Commits · 戴 / test

CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one of those warn about them once and handle them gracefully by recalculating the checksum. Cc: Eric Dumazet <edumazet@google.com> Cc: Vlad Yasevich <vyasevich@gmail.com> Cc: Benjamin Coddington <bcodding@redhat.com> Cc: Tom Herbert <tom@herbertland.com> Signed-off-by:

Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/ipv4/ip_output.c

+5 −3

Original line number	Original line	Diff line number	Diff line
	@@ -533,6 +533,11 @@ int ip_do_fragment(struct net net, struct sock sk, struct sk_buff *skb,

	dev = rt->dst.dev;		dev = rt->dst.dev;

			/* for offloaded checksums cleanup checksum before fragmentation */
			if (skb->ip_summed == CHECKSUM_PARTIAL &&
			(err = skb_checksum_help(skb)))
			goto fail;

	/*		/*
	* Point into the IP datagram header.		* Point into the IP datagram header.
	*/		*/
	@@ -657,9 +662,6 @@ slow_path_clean:
	}		}

	slow_path:		slow_path:
	/* for offloaded checksums cleanup checksum before fragmentation */
	if ((skb->ip_summed == CHECKSUM_PARTIAL) && skb_checksum_help(skb))
	goto fail;
	iph = ip_hdr(skb);		iph = ip_hdr(skb);

	left = skb->len - hlen; /* Space per frame */		left = skb->len - hlen; /* Space per frame */

Admin message