Commit dbb018cd authored Jul 08, 2008 by Darren Jenkins Committed by Herbert Xu Jul 08, 2008

crypto: tcrypt - Fix memory leak in test_cipher



Coverity CID: 2306 & 2307 RESOURCE_LEAK

In the second for loop in test_cipher(), data is allocated space with
kzalloc() and is only ever freed in an error case.
Looking at this loop, data is written to this memory but nothing seems
to read from it. 
So here is a patch removing the allocation, I think this is the right
fix.

Only compile tested.

Signed-off-by: Darren Jenkins <darrenrjenkins@gmailcom>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 7b51ba38

crypto/tcrypt.c

+1 −9

Original line number	Diff line number	Diff line
		@@ -586,12 +586,6 @@ static void test_cipher(char *algo, int enc,
		j = 0;
		for (i = 0; i < tcount; i++) {

		data = kzalloc(template[i].ilen, GFP_KERNEL);
		if (!data)
		continue;

		memcpy(data, template[i].input, template[i].ilen);

		if (template[i].iv)
		memcpy(iv, template[i].iv, MAX_IVLEN);
		else
		@@ -613,11 +607,9 @@ static void test_cipher(char *algo, int enc,
		printk("setkey() failed flags=%x\n",
		crypto_ablkcipher_get_flags(tfm));

		if (!template[i].fail) {
		kfree(data);
		if (!template[i].fail)
		goto out;
		}
		}

		temp = 0;
		sg_init_table(sg, template[i].np);

Admin message