Commit dbab8128 authored Feb 07, 2008 by Maciej W. Rozycki Committed by Linus Torvalds Feb 07, 2008

dz: always check if it is safe to console_putchar()



Polled transmission is tricky enough with the DZ11 design.  While "loop" is
set to a high value, conceptually you are not allowed to transmit without
checking whether the device offers the right transmission line (yes, it is the
device that selects the line -- the driver has no control over it other than
disabling the transmitter offered if it is the wrong one), so the loop has to
be run at least once.

Well, the '1977 or PDP11 view of how serial lines should be handled...  Except
that the serial interface used to be quite an impressive board back then
rather than chip.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d4dd1467

drivers/serial/dz.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -685,7 +685,7 @@ static void dz_console_putchar(struct uart_port *uport, int ch)
		iob();
		spin_unlock_irqrestore(&dport->port.lock, flags);

		while (loops--) {
		do {
		trdy = dz_in(dport, DZ_CSR);
		if (!(trdy & DZ_TRDY))
		continue;
		@@ -696,7 +696,7 @@ static void dz_console_putchar(struct uart_port *uport, int ch)
		dz_out(dport, DZ_TCR, mask);
		iob();
		udelay(2);
		}
		} while (loops--);

		if (loops) /* Cannot send otherwise. */
		dz_out(dport, DZ_TDR, ch);

Admin message