Commit dba76c03 authored by Maxim Levitsky's avatar Maxim Levitsky Committed by David Woodhouse
Browse files

mtd: blkdevs: fix crash related to sysfs attributes.



Remove the attributes group before disk to avoid use after free

Signed-off-by: default avatarMaxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: default avatarArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent ef41e1bb
Loading
Loading
Loading
Loading
+4 −3
Original line number Original line Diff line number Diff line
@@ -410,13 +410,14 @@ int del_mtd_blktrans_dev(struct mtd_blktrans_dev *old)
		BUG();
		BUG();
	}
	}


	/* Stop new requests to arrive */
	del_gendisk(old->disk);

	if (old->disk_attributes)
	if (old->disk_attributes)
		sysfs_remove_group(&disk_to_dev(old->disk)->kobj,
		sysfs_remove_group(&disk_to_dev(old->disk)->kobj,
						old->disk_attributes);
						old->disk_attributes);


	/* Stop new requests to arrive */
	del_gendisk(old->disk);


	/* Stop the thread */
	/* Stop the thread */
	kthread_stop(old->thread);
	kthread_stop(old->thread);