Commit dba5ccc7 authored by Bart Van Assche's avatar Bart Van Assche Committed by Nicholas Bellinger
Browse files

target: Remove an unused variable 



The num_node_acls member in struct se_portal_group is modified
by several functions but is never read. Hence remove it.

Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Andy Grover <agrover@redhat.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 9b3118ce

drivers/target/target_core_tpg.c

+0 −3
Original line number Diff line number Diff line
@@ -219,7 +219,6 @@ static void target_add_node_acl(struct se_node_acl *acl) 


	mutex_lock(&tpg->acl_node_mutex);

	list_add_tail(&acl->acl_list, &tpg->acl_node_list);

	tpg->num_node_acls++;

	mutex_unlock(&tpg->acl_node_mutex);



	pr_debug("%s_TPG[%hu] - Added %s ACL with TCQ Depth: %d for %s"
@@ -318,7 +317,6 @@ void core_tpg_del_initiator_node_acl(struct se_node_acl *acl) 
		acl->dynamic_node_acl = 0;

	}

	list_del(&acl->acl_list);

	tpg->num_node_acls--;

	mutex_unlock(&tpg->acl_node_mutex);



	spin_lock_irqsave(&acl->nacl_sess_lock, flags);
@@ -595,7 +593,6 @@ int core_tpg_deregister(struct se_portal_group *se_tpg) 
	 */

	list_for_each_entry_safe(nacl, nacl_tmp, &node_list, acl_list) {

		list_del(&nacl->acl_list);

		se_tpg->num_node_acls--;



		core_tpg_wait_for_nacl_pr_ref(nacl);

		core_free_device_list_for_node(nacl, se_tpg);

drivers/target/target_core_transport.c

+0 −1
Original line number Diff line number Diff line
@@ -502,7 +502,6 @@ void transport_deregister_session(struct se_session *se_sess) 
	if (se_nacl && se_nacl->dynamic_node_acl) {

		if (!se_tfo->tpg_check_demo_mode_cache(se_tpg)) {

			list_del(&se_nacl->acl_list);

			se_tpg->num_node_acls--;

			drop_nacl = true;

		}

	}

include/target/target_core_base.h

+0 −2
Original line number Diff line number Diff line
@@ -868,8 +868,6 @@ struct se_portal_group { 
	 * Negative values can be used by fabric drivers for internal use TPGs.

	 */

	int			proto_id;

	/* Number of ACLed Initiator Nodes for this TPG */

	u32			num_node_acls;

	/* Used for PR SPEC_I_PT=1 and REGISTER_AND_MOVE */

	atomic_t		tpg_pr_ref_count;

	/* Spinlock for adding/removing ACLed Nodes */

CRA Git | Maintained and supported by SUSTech CRA and CCSE