Gitlab 现已全面支持 git over ssh 与 git over https。通过 HTTPS 访问请配置带有 read_repository / write_repository 权限的 Personal access token。通过 SSH 端口访问请使用 22 端口或 13389 端口。如果使用CAS注册了账户但不知道密码，可以自行至设置中更改；如有其他问题，请发邮件至 service@cra.moe 寻求协助。

Commit db4bf822 authored Apr 17, 2019 by Bart Van Assche Committed by Martin K. Petersen Apr 29, 2019

scsi: qla2xxx: Complain loudly about reference count underflow

A reference count underflow is a severe bug. Hence complain loudly if a
reference count underflow happens.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent d4556a49

drivers/scsi/qla2xxx/qla_nvme.c

+5 −10

Original line number	Original line	Diff line number	Diff line
	@@ -131,11 +131,8 @@ static void qla_nvme_sp_ls_done(void *ptr, int res)
	struct nvmefc_ls_req *fd;		struct nvmefc_ls_req *fd;
	struct nvme_private *priv;		struct nvme_private *priv;

	if (atomic_read(&sp->ref_count) == 0) {		if (WARN_ON_ONCE(atomic_read(&sp->ref_count) == 0))
	ql_log(ql_log_warn, sp->fcport->vha, 0x2123,
	"SP reference-count to ZERO on LS_done -- sp=%p.\n", sp);
	return;		return;
	}

	atomic_dec(&sp->ref_count);		atomic_dec(&sp->ref_count);

	@@ -160,6 +157,9 @@ static void qla_nvme_sp_done(void *ptr, int res)
	nvme = &sp->u.iocb_cmd;		nvme = &sp->u.iocb_cmd;
	fd = nvme->u.nvme.desc;		fd = nvme->u.nvme.desc;

			if (WARN_ON_ONCE(atomic_read(&sp->ref_count) == 0))
			return;

	atomic_dec(&sp->ref_count);		atomic_dec(&sp->ref_count);

	if (res == QLA_SUCCESS) {		if (res == QLA_SUCCESS) {
	@@ -199,13 +199,8 @@ static void qla_nvme_abort_work(struct work_struct *work)
	return;		return;
	}		}

	if (atomic_read(&sp->ref_count) == 0) {		if (WARN_ON_ONCE(atomic_read(&sp->ref_count) == 0))
	WARN_ON(1);
	ql_log(ql_log_info, fcport->vha, 0xffff,
	"%s: command already aborted on sp: %p\n",
	__func__, sp);
	return;		return;
	}

	rval = ha->isp_ops->abort_command(sp);		rval = ha->isp_ops->abort_command(sp);

drivers/scsi/qla2xxx/qla_os.c

+2 −14

Original line number	Original line	Diff line number	Diff line
	@@ -716,14 +716,8 @@ qla2x00_sp_compl(void *ptr, int res)
	struct scsi_cmnd *cmd = GET_CMD_SP(sp);		struct scsi_cmnd *cmd = GET_CMD_SP(sp);
	struct completion *comp = sp->comp;		struct completion *comp = sp->comp;

	if (atomic_read(&sp->ref_count) == 0) {		if (WARN_ON_ONCE(atomic_read(&sp->ref_count) == 0))
	ql_dbg(ql_dbg_io, sp->vha, 0x3015,
	"SP reference-count to ZERO -- sp=%p cmd=%p.\n",
	sp, GET_CMD_SP(sp));
	if (ql2xextended_error_logging & ql_dbg_io)
	WARN_ON(atomic_read(&sp->ref_count) == 0);
	return;		return;
	}

	atomic_dec(&sp->ref_count);		atomic_dec(&sp->ref_count);

	@@ -827,14 +821,8 @@ qla2xxx_qpair_sp_compl(void *ptr, int res)
	struct scsi_cmnd *cmd = GET_CMD_SP(sp);		struct scsi_cmnd *cmd = GET_CMD_SP(sp);
	struct completion *comp = sp->comp;		struct completion *comp = sp->comp;

	if (atomic_read(&sp->ref_count) == 0) {		if (WARN_ON_ONCE(atomic_read(&sp->ref_count) == 0))
	ql_dbg(ql_dbg_io, sp->fcport->vha, 0x3079,
	"SP reference-count to ZERO -- sp=%p cmd=%p.\n",
	sp, GET_CMD_SP(sp));
	if (ql2xextended_error_logging & ql_dbg_io)
	WARN_ON(atomic_read(&sp->ref_count) == 0);
	return;		return;
	}

	atomic_dec(&sp->ref_count);		atomic_dec(&sp->ref_count);

CRA Git | Maintained and supported by SUSTech CRA and CCSE