Unverified Commit db2a1732 authored Aug 04, 2019 by Nishka Dasgupta Committed by Mark Brown Aug 05, 2019

regulator: core: Add of_node_put() before return



Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
two places.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190804162023.5673-1-nishkadg.linux@gmail.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 47241933

drivers/regulator/core.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -380,9 +380,12 @@ static struct device_node of_get_child_regulator(struct device_node parent,

		if (!regnode) {
		regnode = of_get_child_regulator(child, prop_name);
		if (regnode)
		if (regnode) {
		of_node_put(child);
		return regnode;
		}
		} else {
		of_node_put(child);
		return regnode;
		}
		}

Admin message