Btrfs: hold the ordered operations mutex when waiting on ordered extents (db1d607d) · Commits · 戴 / test

We need to hold the ordered_operations mutex while waiting on ordered extents since we splice and run the ordered extents list. We need to make sure anybody else who wants to wait on ordered extents does actually wait for them to be completed. This will keep us from bailing out of flushing in case somebody is already waiting on ordered extents to complete. Thanks, Signed-off-by:

Josef Bacik <jbacik@fusionio.com>

fs/btrfs/ordered-data.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -557,6 +557,7 @@ void btrfs_wait_ordered_extents(struct btrfs_root *root, int delay_iput)
	INIT_LIST_HEAD(&splice);		INIT_LIST_HEAD(&splice);
	INIT_LIST_HEAD(&works);		INIT_LIST_HEAD(&works);

			mutex_lock(&root->fs_info->ordered_operations_mutex);
	spin_lock(&root->fs_info->ordered_extent_lock);		spin_lock(&root->fs_info->ordered_extent_lock);
	list_splice_init(&root->fs_info->ordered_extents, &splice);		list_splice_init(&root->fs_info->ordered_extents, &splice);
	while (!list_empty(&splice)) {		while (!list_empty(&splice)) {
	@@ -600,6 +601,7 @@ void btrfs_wait_ordered_extents(struct btrfs_root *root, int delay_iput)

	cond_resched();		cond_resched();
	}		}
			mutex_unlock(&root->fs_info->ordered_operations_mutex);
	}		}

	/*		/*

Admin message