Commit db186382 authored Sep 26, 2018 by Quinn Tran Committed by Martin K. Petersen Sep 27, 2018

scsi: qla2xxx: Fix NVMe Target discovery



This patch fixes issue when remoteport registers itself as both FCP and
FC-NVMe with the switch, driver will pick FC-NVMe personality as default when
scanning for targets.

Driver was using comaprative operator instead of bitwise operator to check for
fc4_type for both FCP and FC-NVME.

Fixes: 2b5b9647 ("scsi: qla2xxx: Fix FC-NVMe LUN discovery")
Cc: <stable@vger.kernel.org>
Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent f7d61c99

drivers/scsi/qla2xxx/qla_os.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -4880,10 +4880,10 @@ void qla24xx_create_new_sess(struct scsi_qla_host vha, struct qla_work_evt e)
		fcport->d_id = e->u.new_sess.id;
		fcport->flags \|= FCF_FABRIC_DEVICE;
		fcport->fw_login_state = DSC_LS_PLOGI_PEND;
		if (e->u.new_sess.fc4_type == FS_FC4TYPE_FCP)
		if (e->u.new_sess.fc4_type & FS_FC4TYPE_FCP)
		fcport->fc4_type = FC4_TYPE_FCP_SCSI;

		if (e->u.new_sess.fc4_type == FS_FC4TYPE_NVME) {
		if (e->u.new_sess.fc4_type & FS_FC4TYPE_NVME) {
		fcport->fc4_type = FC4_TYPE_OTHER;
		fcport->fc4f_nvme = FC4_TYPE_NVME;
		}

Admin message