Commit db0503e4 authored Oct 21, 2019 by Peter Zijlstra Committed by Ingo Molnar Oct 28, 2019

perf/core: Optimize perf_install_in_event()



Andi reported that when creating a lot of events, a lot of time is
spent in IPIs and asked if it would be possible to elide some of that.

Now when, as for example the perf-tool always does, events are created
disabled, then these events will not need to be scheduled when added
to the context (they're still disable) and therefore the IPI is not
required -- except for the very first event, that will need to set
ctx->is_active.

( It might be possible to set ctx->is_active remotely for cpu_ctx, but
  we really need the IPI for task_ctx, so lets not make that
  distinction. )

Also use __perf_effective_state() since group events depend on the
state of the leader, if the leader is OFF, the whole group is OFF.

So when sibling events are created enabled (XXX check tool) then we
only need a single IPI to create and enable the whole group (+ that
initial IPI to initialize the context).

Suggested-by: Andi Kleen <andi@firstfloor.org>
Reported-by: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: acme@kernel.org
Cc: kan.liang@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent c2b98a86

kernel/events/core.c

+19 −0

Original line number	Diff line number	Diff line
		@@ -2666,6 +2666,25 @@ perf_install_in_context(struct perf_event_context *ctx,
		*/
		smp_store_release(&event->ctx, ctx);

		/*
		* perf_event_attr::disabled events will not run and can be initialized
		* without IPI. Except when this is the first event for the context, in
		* that case we need the magic of the IPI to set ctx->is_active.
		*
		* The IOC_ENABLE that is sure to follow the creation of a disabled
		* event will issue the IPI and reprogram the hardware.
		*/
		if (__perf_effective_state(event) == PERF_EVENT_STATE_OFF && ctx->nr_events) {
		raw_spin_lock_irq(&ctx->lock);
		if (ctx->task == TASK_TOMBSTONE) {
		raw_spin_unlock_irq(&ctx->lock);
		return;
		}
		add_event_to_ctx(event, ctx);
		raw_spin_unlock_irq(&ctx->lock);
		return;
		}

		if (!task) {
		cpu_function_call(cpu, __perf_install_in_context, event);
		return;

Admin message