Commit db0487ab authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

arm: dump: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Russell King <linux@armlinux.org.uk>
Cc: Jinbum Park <jinb.park7@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Acked-by: default avatarLaura Abbott <labbott@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 30ed997a

arch/arm/include/asm/ptdump.h

+3 −6
Original line number Diff line number Diff line
@@ -21,13 +21,10 @@ struct ptdump_info { 


void ptdump_walk_pgd(struct seq_file *s, struct ptdump_info *info);

#ifdef CONFIG_ARM_PTDUMP_DEBUGFS

int ptdump_debugfs_register(struct ptdump_info *info, const char *name);

void ptdump_debugfs_register(struct ptdump_info *info, const char *name);

#else

static inline int ptdump_debugfs_register(struct ptdump_info *info,

					const char *name)

{

	return 0;

}

static inline void ptdump_debugfs_register(struct ptdump_info *info,

					   const char *name) { }

#endif /* CONFIG_ARM_PTDUMP_DEBUGFS */



void ptdump_check_wx(void);

arch/arm/mm/dump.c

+2 −2
Original line number Diff line number Diff line
@@ -450,7 +450,7 @@ void ptdump_check_wx(void) 
static int ptdump_init(void)

{

	ptdump_initialize();

	return ptdump_debugfs_register(&kernel_ptdump_info,

					"kernel_page_tables");

	ptdump_debugfs_register(&kernel_ptdump_info, "kernel_page_tables");

	return 0;

}

__initcall(ptdump_init);

arch/arm/mm/ptdump_debugfs.c

+2 −6
Original line number Diff line number Diff line
@@ -24,11 +24,7 @@ static const struct file_operations ptdump_fops = { 
	.release	= single_release,

};



int ptdump_debugfs_register(struct ptdump_info *info, const char *name)

void ptdump_debugfs_register(struct ptdump_info *info, const char *name)

{

	struct dentry *pe;



	pe = debugfs_create_file(name, 0400, NULL, info, &ptdump_fops);

	return pe ? 0 : -ENOMEM;



	debugfs_create_file(name, 0400, NULL, info, &ptdump_fops);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE