staging:rtl8192u: Remove potential memory leak (daf9a56c) · Commits · 戴 / test

Add call to ieee80211_networks_free() to avoid potential memory leak if allocation of pHTInfo fails. If the third allocation fails only the first successful allocation is freed, not the second. Signed-off-by:

John Whitmore <johnfwhitmore@gmail.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -159,6 +159,11 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
		ieee->pHTInfo = kzalloc(sizeof(RT_HIGH_THROUGHPUT), GFP_KERNEL);
		if (ieee->pHTInfo == NULL) {
		IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc memory for HTInfo\n");

		/* By this point in code ieee80211_networks_allocate() has been
		* successfully called so the memory allocated should be freed
		*/
		ieee80211_networks_free(ieee);
		goto failed;
		}
		HTUpdateDefaultSetting(ieee);

Admin message