kill-the-BKL/reiserfs: provide a tool to lock only once the write lock (daf88c89) · Commits · 戴 / test

Sometimes we don't want to recursively hold the per superblock write lock because we want to be sure it is actually released when we come to sleep. This patch introduces the necessary tools for that. reiserfs_write_lock_once() does the same job than reiserfs_write_lock() except that it won't try to acquire recursively the lock if the current task already owns it. Also the lock_depth before the call of this function is returned. reiserfs_write_unlock_once() unlock only if reiserfs_write_lock_once() returned a depth equal to -1, ie: only if it actually locked. Signed-off-by:

Frederic Weisbecker <fweisbec@gmail.com> Cc: Alessio Igor Bogani <abogani@texware.it> Cc: Jeff Mahoney <jeffm@suse.com> Cc: Alexander Beregalov <a.beregalov@gmail.com> Cc: Chris Mason <chris.mason@oracle.com> LKML-Reference: <1239680065-25013-2-git-send-email-fweisbec@gmail.com> Signed-off-by:

Ingo Molnar <mingo@elte.hu>

fs/reiserfs/lock.c

+26 −0

Original line number	Diff line number	Diff line
		@@ -49,6 +49,32 @@ void reiserfs_write_unlock(struct super_block *s)
		}
		}

		/*
		* If we already own the lock, just exit and don't increase the depth.
		* Useful when we don't want to lock more than once.
		*
		* We always return the lock_depth we had before calling
		* this function.
		*/
		int reiserfs_write_lock_once(struct super_block *s)
		{
		struct reiserfs_sb_info *sb_i = REISERFS_SB(s);

		if (sb_i->lock_owner != current) {
		mutex_lock(&sb_i->lock);
		sb_i->lock_owner = current;
		return sb_i->lock_depth++;
		}

		return sb_i->lock_depth;
		}

		void reiserfs_write_unlock_once(struct super_block *s, int lock_depth)
		{
		if (lock_depth == -1)
		reiserfs_write_unlock(s);
		}

		/*
		* Utility function to force a BUG if it is called without the superblock
		* write lock held. caller is the string printed just before calling BUG()

include/linux/reiserfs_fs.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -59,6 +59,8 @@
		*/
		void reiserfs_write_lock(struct super_block *s);
		void reiserfs_write_unlock(struct super_block *s);
		int reiserfs_write_lock_once(struct super_block *s);
		void reiserfs_write_unlock_once(struct super_block *s, int lock_depth);

		struct fid;

Admin message