Commit daf7b799 authored Sep 02, 2013 by Dave Chinner Committed by Ben Myers Sep 10, 2013

xfs: set remote symlink buffer type for recovery



The logging of a remote symlink block does not set the buffer type
being logged, and hence on recovery the type of buffer is not
recognised and hence CRCs are not calculated after replay. This
results in log recoery throwing:

XFS (vdc): Unknown buffer type 0

errors, and subsequent reads of the symlink failing CRC
verification. Found via fsstress + godown.

Reported by: Michael L. Semon <mlsemon35@gmail.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ben Myers <bpm@sgi.com>

parent 638f4416

fs/xfs/xfs_symlink.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -41,6 +41,7 @@
		#include "xfs_trans_space.h"
		#include "xfs_trace.h"
		#include "xfs_symlink.h"
		#include "xfs_buf_item.h"

		/* ----- Kernel only functions below ----- */
		STATIC int
		@@ -363,6 +364,7 @@ xfs_symlink(
		pathlen -= byte_cnt;
		offset += byte_cnt;

		xfs_trans_buf_set_type(tp, bp, XFS_BLFT_SYMLINK_BUF);
		xfs_trans_log_buf(tp, bp, 0, (buf + byte_cnt - 1) -
		(char *)bp->b_addr);
		}

Admin message