Commit daebc534 authored Mar 23, 2012 by Andy Whitcroft Committed by Linus Torvalds Mar 23, 2012

checkpatch: catch [ ... ] usage when not at the beginning of definition



Handle the [ A ... B ] form deeper into a definition, for example:

    static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
	    {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
	    {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
    };

Reported-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 11232688

scripts/checkpatch.pl

+1 −1

Original line number	Diff line number	Diff line
		@@ -2391,7 +2391,7 @@ sub process {
		my ($where, $prefix) = ($-[1], $1);
		if ($prefix !~ /$Type\s+$/ &&
		($where != 0 \|\| $prefix !~ /^.\s+$/) &&
		$prefix !~ /{\s+$/) {
		$prefix !~ /[{,]\s+$/) {
		ERROR("BRACKET_SPACE",
		"space prohibited before open square bracket '['\n" . $herecurr);
		}

Admin message