Commit daebabd5 authored by Tony Lindgren's avatar Tony Lindgren Committed by Lee Jones
Browse files

mfd: twl4030-power: Fix PM idle pin configuration to not conflict with regulators 



Commit 43fef47f (mfd: twl4030-power: Add a configuration to turn
off oscillator during off-idle) added support for configuring the PMIC
to cut off resources during deeper idle states to save power.

This however caused regression for n900 display power that needed the
PMIC configuration to be disabled with commit d937678a (ARM: dts:
Revert enabling of twl configuration for n900).

Turns out the root cause of the problem is that we must use
TWL4030_RESCONFIG_UNDEF instead of DEV_GRP_NULL to avoid disabling
regulators that may have been enabled before the init function
for twl4030-power.c runs. With TWL4030_RESCONFIG_UNDEF we let the
regulator framework control the regulators like it should. Here we
need to only configure the sys_clken and sys_off_mode triggers for
the regulators that cannot be done by the regulator framework as
it's not running at that point.

This allows us to enable the PMIC configuration for n900.

Fixes: 43fef47f (mfd: twl4030-power: Add a configuration to turn off oscillator during off-idle)

Cc: stable@vger.kernel.org # v3.16
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Tested-by: default avatarAaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent bc804360

arch/arm/boot/dts/omap3-n900.dts

+1 −1
Original line number Diff line number Diff line
@@ -353,7 +353,7 @@ 
	};



	twl_power: power {

		compatible = "ti,twl4030-power-n900";

		compatible = "ti,twl4030-power-n900", "ti,twl4030-power-idle-osc-off";

		ti,use_poweroff;

	};

};

drivers/mfd/twl4030-power.c

+10 −10
Original line number Diff line number Diff line
@@ -724,24 +724,24 @@ static struct twl4030_script *omap3_idle_scripts[] = { 
 * above.

 */

static struct twl4030_resconfig omap3_idle_rconfig[] = {

	TWL_REMAP_SLEEP(RES_VAUX1, DEV_GRP_NULL, 0, 0),

	TWL_REMAP_SLEEP(RES_VAUX2, DEV_GRP_NULL, 0, 0),

	TWL_REMAP_SLEEP(RES_VAUX3, DEV_GRP_NULL, 0, 0),

	TWL_REMAP_SLEEP(RES_VAUX4, DEV_GRP_NULL, 0, 0),

	TWL_REMAP_SLEEP(RES_VMMC1, DEV_GRP_NULL, 0, 0),

	TWL_REMAP_SLEEP(RES_VMMC2, DEV_GRP_NULL, 0, 0),

	TWL_REMAP_SLEEP(RES_VAUX1, TWL4030_RESCONFIG_UNDEF, 0, 0),

	TWL_REMAP_SLEEP(RES_VAUX2, TWL4030_RESCONFIG_UNDEF, 0, 0),

	TWL_REMAP_SLEEP(RES_VAUX3, TWL4030_RESCONFIG_UNDEF, 0, 0),

	TWL_REMAP_SLEEP(RES_VAUX4, TWL4030_RESCONFIG_UNDEF, 0, 0),

	TWL_REMAP_SLEEP(RES_VMMC1, TWL4030_RESCONFIG_UNDEF, 0, 0),

	TWL_REMAP_SLEEP(RES_VMMC2, TWL4030_RESCONFIG_UNDEF, 0, 0),

	TWL_REMAP_OFF(RES_VPLL1, DEV_GRP_P1, 3, 1),

	TWL_REMAP_SLEEP(RES_VPLL2, DEV_GRP_P1, 0, 0),

	TWL_REMAP_SLEEP(RES_VSIM, DEV_GRP_NULL, 0, 0),

	TWL_REMAP_SLEEP(RES_VDAC, DEV_GRP_NULL, 0, 0),

	TWL_REMAP_SLEEP(RES_VSIM, TWL4030_RESCONFIG_UNDEF, 0, 0),

	TWL_REMAP_SLEEP(RES_VDAC, TWL4030_RESCONFIG_UNDEF, 0, 0),

	TWL_REMAP_SLEEP(RES_VINTANA1, TWL_DEV_GRP_P123, 1, 2),

	TWL_REMAP_SLEEP(RES_VINTANA2, TWL_DEV_GRP_P123, 0, 2),

	TWL_REMAP_SLEEP(RES_VINTDIG, TWL_DEV_GRP_P123, 1, 2),

	TWL_REMAP_SLEEP(RES_VIO, TWL_DEV_GRP_P123, 2, 2),

	TWL_REMAP_OFF(RES_VDD1, DEV_GRP_P1, 4, 1),

	TWL_REMAP_OFF(RES_VDD2, DEV_GRP_P1, 3, 1),

	TWL_REMAP_SLEEP(RES_VUSB_1V5, DEV_GRP_NULL, 0, 0),

	TWL_REMAP_SLEEP(RES_VUSB_1V8, DEV_GRP_NULL, 0, 0),

	TWL_REMAP_SLEEP(RES_VUSB_1V5, TWL4030_RESCONFIG_UNDEF, 0, 0),

	TWL_REMAP_SLEEP(RES_VUSB_1V8, TWL4030_RESCONFIG_UNDEF, 0, 0),

	TWL_REMAP_SLEEP(RES_VUSB_3V1, TWL_DEV_GRP_P123, 0, 0),

	/* Resource #20 USB charge pump skipped */

	TWL_REMAP_SLEEP(RES_REGEN, TWL_DEV_GRP_P123, 2, 1),

CRA Git | Maintained and supported by SUSTech CRA and CCSE