clk: qcom: clk-rpmh: Wait for completion when enabling clocks (dad4e7fd) · Commits · 戴 / test

The current implementation always uses rpmh_write_async, which doesn't wait for completion. That's fine for disable requests since there's no immediate need for the clocks and they can be disabled in the background. However, for enable requests we need to ensure the clocks are actually enabled before returning to the client. Otherwise, clients can end up accessing their HW before the necessary clocks are enabled, which can lead to bus errors. Use the synchronous version of this API (rpmh_write) for enable requests in the active set to ensure completion. Completion isn't required for sleep/wake sets, since they don't take effect until after we enter sleep. All rpmh requests are automatically flushed prior to entering sleep. Fixes: ("clk: qcom: clk-rpmh: Add QCOM RPMh clock driver") Signed-off-by:

Mike Tipton <mdtipton@codeaurora.org> Link: https://lkml.kernel.org/r/20200215021232.1149-1-mdtipton@codeaurora.org Reviewed-by:

Bjorn Andersson <bjorn.andersson@linaro.org> [sboyd@kernel.org: Reorg code a bit for readability, rename to 'wait' to make local variable not conflict with completion.h mechanism] Signed-off-by:

Stephen Boyd <sboyd@kernel.org>

drivers/clk/qcom/clk-rpmh.c

+13 −2

Original line number	Diff line number	Diff line
		@@ -143,12 +143,22 @@ static inline bool has_state_changed(struct clk_rpmh *c, u32 state)
		!= (c->aggr_state & BIT(state));
		}

		static int clk_rpmh_send(struct clk_rpmh *c, enum rpmh_state state,
		struct tcs_cmd *cmd, bool wait)
		{
		if (wait)
		return rpmh_write(c->dev, state, cmd, 1);

		return rpmh_write_async(c->dev, state, cmd, 1);
		}

		static int clk_rpmh_send_aggregate_command(struct clk_rpmh *c)
		{
		struct tcs_cmd cmd = { 0 };
		u32 cmd_state, on_val;
		enum rpmh_state state = RPMH_SLEEP_STATE;
		int ret;
		bool wait;

		cmd.addr = c->res_addr;
		cmd_state = c->aggr_state;
		@@ -159,7 +169,8 @@ static int clk_rpmh_send_aggregate_command(struct clk_rpmh *c)
		if (cmd_state & BIT(state))
		cmd.data = on_val;

		ret = rpmh_write_async(c->dev, state, &cmd, 1);
		wait = cmd_state && state == RPMH_ACTIVE_ONLY_STATE;
		ret = clk_rpmh_send(c, state, &cmd, wait);
		if (ret) {
		dev_err(c->dev, "set %s state of %s failed: (%d)\n",
		!state ? "sleep" :
		@@ -267,7 +278,7 @@ static int clk_rpmh_bcm_send_cmd(struct clk_rpmh *c, bool enable)
		cmd.addr = c->res_addr;
		cmd.data = BCM_TCS_CMD(1, enable, 0, cmd_state);

		ret = rpmh_write_async(c->dev, RPMH_ACTIVE_ONLY_STATE, &cmd, 1);
		ret = clk_rpmh_send(c, RPMH_ACTIVE_ONLY_STATE, &cmd, enable);
		if (ret) {
		dev_err(c->dev, "set active state of %s failed: (%d)\n",
		c->res_name, ret);

Admin message