Commit dad42d17 authored Aug 03, 2020 by Jane Chu Committed by Vishal Verma Aug 03, 2020

libnvdimm/security: fix a typo

commit d78c620a ("libnvdimm/security: Introduce a 'frozen' attribute")
introduced a typo, causing a 'nvdimm->sec.flags' update being overwritten
by the subsequent update meant for 'nvdimm->sec.ext_flags'.

Link: https://lore.kernel.org/r/1596494499-9852-1-git-send-email-jane.chu@oracle.com


Fixes: d78c620a ("libnvdimm/security: Introduce a 'frozen' attribute")
Cc: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jane Chu <jane.chu@oracle.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

parent 9f1048d4

drivers/nvdimm/security.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -457,7 +457,7 @@ void __nvdimm_security_overwrite_query(struct nvdimm *nvdimm)
		clear_bit(NDD_WORK_PENDING, &nvdimm->flags);
		put_device(&nvdimm->dev);
		nvdimm->sec.flags = nvdimm_security_flags(nvdimm, NVDIMM_USER);
		nvdimm->sec.flags = nvdimm_security_flags(nvdimm, NVDIMM_MASTER);
		nvdimm->sec.ext_flags = nvdimm_security_flags(nvdimm, NVDIMM_MASTER);
		}

		void nvdimm_security_overwrite_query(struct work_struct *work)

Admin message