mac80211: fail authentication when AP denied authentication (dac211ec) · Commits · 戴 / test

ieee80211_rx_mgmt_auth() doesn't handle denied authentication properly - it authenticates the station and waits for association (for 5 seconds) instead of failing the authentication. Fix it by destroying auth_data and bailing out instead. Signed-off-by:

Eliad Peller <eliad@wizery.com> Acked-by:

Johannes Berg <johannes@sipsolutions.net> Cc: stable@vger.kernel.org #3.4 Signed-off-by:

John W. Linville <linville@tuxdriver.com>

net/mac80211/mlme.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1791,7 +1791,8 @@ ieee80211_rx_mgmt_auth(struct ieee80211_sub_if_data *sdata,
		if (status_code != WLAN_STATUS_SUCCESS) {
		printk(KERN_DEBUG "%s: %pM denied authentication (status %d)\n",
		sdata->name, mgmt->sa, status_code);
		goto out;
		ieee80211_destroy_auth_data(sdata, false);
		return RX_MGMT_CFG80211_RX_AUTH;
		}

		switch (ifmgd->auth_data->algorithm) {
		@@ -1813,7 +1814,6 @@ ieee80211_rx_mgmt_auth(struct ieee80211_sub_if_data *sdata,
		}

		printk(KERN_DEBUG "%s: authenticated\n", sdata->name);
		out:
		ifmgd->auth_data->done = true;
		ifmgd->auth_data->timeout = jiffies + IEEE80211_AUTH_WAIT_ASSOC;
		run_again(ifmgd, ifmgd->auth_data->timeout);

Admin message