Commit dabbd6ab authored Nov 13, 2020 by Zhang Changzhong Committed by Jason Gunthorpe Nov 13, 2020

IB/hfi1: Fix error return code in hfi1_init_dd()

Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Fixes: 4730f4a6 ("IB/hfi1: Activate the dummy netdev")
Link: https://lore.kernel.org/r/1605249747-17942-1-git-send-email-zhangchangzhong@huawei.com


Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

parent b1e678bf

drivers/infiniband/hw/hfi1/chip.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -15245,7 +15245,8 @@ int hfi1_init_dd(struct hfi1_devdata *dd)
		& CCE_REVISION_SW_MASK);

		/* alloc netdev data */
		if (hfi1_netdev_alloc(dd))
		ret = hfi1_netdev_alloc(dd);
		if (ret)
		goto bail_cleanup;

		ret = set_up_context_variables(dd);

Admin message