Commit dab23422 authored Oct 23, 2020 by Michael Ellerman Committed by Jakub Kicinski Oct 23, 2020

net: ucc_geth: Drop extraneous parentheses in comparison



Clang warns about the extra parentheses in this comparison:

  drivers/net/ethernet/freescale/ucc_geth.c:1361:28:
  warning: equality comparison with extraneous parentheses
    if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII))
         ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~

It seems clear the intent here is to do a comparison not an
assignment, so drop the extra parentheses to avoid any confusion.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201023033236.3296988-1-mpe@ellerman.id.au


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 0c3b7f4b

drivers/net/ethernet/freescale/ucc_geth.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1358,7 +1358,7 @@ static int adjust_enet_interface(struct ucc_geth_private *ugeth)
		(ugeth->phy_interface == PHY_INTERFACE_MODE_RTBI)) {
		upsmr \|= UCC_GETH_UPSMR_TBIM;
		}
		if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII))
		if (ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII)
		upsmr \|= UCC_GETH_UPSMR_SGMM;

		out_be32(&uf_regs->upsmr, upsmr);

Admin message