Commit da8de392 authored Jul 17, 2008 by Mats Erik Andersson Committed by Jeff Garzik Sep 24, 2008

8139too: [cosmetic] fix incorrect register for flash-rom



I would like to submit a correction to the driver

     drivers/net/8139too.c,

which in no way changes the compiled driver, but does change
the value of a previously incorrect value for the configuration
register address of Flash PROM on the network processor rtl8139C.
This corrected value is in accordance with the datasheet
for rtl8139C, and in addition this new value is indeed used
in other functional drivers that use this adapter for
programming a Flash memory chip in situ. But as said,
the two new constants are never referenced in the driver
maintained by you: they are only informational and correct!

Mats Erik Andersson, meand@users.sourceforge.net

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent cd0fce03

drivers/net/8139too.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -309,7 +309,7 @@ enum RTL8139_registers {
		Cfg9346 = 0x50,
		Config0 = 0x51,
		Config1 = 0x52,
		FlashReg = 0x54,
		TimerInt = 0x54,
		MediaStatus = 0x58,
		Config3 = 0x59,
		Config4 = 0x5A, /* absent on RTL-8139A */
		@@ -325,6 +325,7 @@ enum RTL8139_registers {
		FIFOTMS = 0x70, /* FIFO Control and test. */
		CSCR = 0x74, /* Chip Status and Configuration Register. */
		PARA78 = 0x78,
		FlashReg = 0xD4, /* Communication with Flash ROM, four bytes. */
		PARA7c = 0x7c, /* Magic transceiver parameter register. */
		Config5 = 0xD8, /* absent on RTL-8139A */
		};

Admin message