Commit da89a7a2 authored May 22, 2008 by Steven Rostedt Committed by Thomas Gleixner May 26, 2008

ftrace: remove printks from irqsoff trace



Printing out new max latencies was fine for the old RT tracer. But for
mainline it is a bit messy. We also need to test if the run queue
is locked before we can do the print. This means that we may not be
printing out latencies if the run queue is locked on another CPU.
This produces inconsistencies in the output.

This patch simply removes the print altogether.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Cc: pq@iki.fi
Cc: proski@gnu.org
Cc: sandmann@redhat.com
Cc: a.p.zijlstra@chello.nl
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 7e18d8e7

kernel/trace/trace_irqsoff.c

+0 −16

Original line number	Diff line number	Diff line
		@@ -165,22 +165,6 @@ check_critical_timing(struct trace_array *tr,

		update_max_tr_single(tr, current, cpu);

		if (!runqueue_is_locked()) {
		if (tracing_thresh) {
		printk(KERN_INFO "(%16s-%-5d\|#%d): %lu us critical"
		" section violates %lu us threshold.\n",
		current->comm, current->pid,
		raw_smp_processor_id(),
		latency, nsecs_to_usecs(tracing_thresh));
		} else {
		printk(KERN_INFO "(%16s-%-5d\|#%d): new %lu us"
		" maximum-latency critical section.\n",
		current->comm, current->pid,
		raw_smp_processor_id(),
		latency);
		}
		}

		max_sequence++;

		out_unlock:

Admin message