Commit da899625 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mike Snitzer
Browse files

dm ioctl: use struct_size() helper in retrieve_deps()



One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct dm_target_deps {
      ...
        __u64 dev[0];   /* out */
};

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

This code was detected with the help of Coccinelle.

Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent a143e172
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1471,7 +1471,7 @@ static void retrieve_deps(struct dm_table *table,
	/*
	 * Check we have enough space.
	 */
	needed = sizeof(*deps) + (sizeof(*deps->dev) * count);
	needed = struct_size(deps, dev, count);
	if (len < needed) {
		param->flags |= DM_BUFFER_FULL_FLAG;
		return;