Commit da837bd6 authored Mar 23, 2020 by Peter Zijlstra Committed by Ingo Molnar Apr 22, 2020

objtool: Avoid iterating !text section symbols



validate_functions() iterates all sections their symbols; this is
pointless to do for !text sections as they won't have instructions
anyway.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lkml.kernel.org/r/20200416115119.346582716@infradead.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 6804c1af

tools/objtool/check.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -2551,8 +2551,12 @@ static int validate_functions(struct objtool_file *file)
		struct section *sec;
		int warnings = 0;

		for_each_sec(file, sec)
		for_each_sec(file, sec) {
		if (!(sec->sh.sh_flags & SHF_EXECINSTR))
		continue;

		warnings += validate_section(file, sec);
		}

		return warnings;
		}

Admin message