Commit da73511d authored by Johannes Berg's avatar Johannes Berg Committed by Reinette Chatre
Browse files

iwlwifi: improve station debugfs 



The stations debugfs entry doesn't even show
the stations' MAC addresses Also, the TID
information is formatted very oddly, and
misses the important tfds_in_queue variable.
Fix this to make the file more useful.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarReinette Chatre <reinette.chatre@intel.com>
parent 1ff504e0

drivers/net/wireless/iwlwifi/iwl-debugfs.c

+25 −35
Original line number Diff line number Diff line
@@ -303,46 +303,36 @@ static ssize_t iwl_dbgfs_stations_read(struct file *file, char __user *user_buf, 


	for (i = 0; i < max_sta; i++) {

		station = &priv->stations[i];

		if (station->used) {

			pos += scnprintf(buf + pos, bufsz - pos,

					"station %d:\ngeneral data:\n", i+1);

			pos += scnprintf(buf + pos, bufsz - pos, "id: %u\n",

					station->sta.sta.sta_id);

			pos += scnprintf(buf + pos, bufsz - pos, "mode: %u\n",

					station->sta.mode);

		if (!station->used)

			continue;

		pos += scnprintf(buf + pos, bufsz - pos,

					"flags: 0x%x\n",

				 "station %d - addr: %pM, flags: %#x\n",

				 i, station->sta.sta.addr,

				 station->sta.station_flags_msk);

			pos += scnprintf(buf + pos, bufsz - pos, "tid data:\n");

			pos += scnprintf(buf + pos, bufsz - pos,

					"seq_num\t\ttxq_id");

		pos += scnprintf(buf + pos, bufsz - pos,

					"\tframe_count\twait_for_ba\t");

				"TID\tseq_num\ttxq_id\tframes\ttfds\t");

		pos += scnprintf(buf + pos, bufsz - pos,

					"start_idx\tbitmap0\t");

			pos += scnprintf(buf + pos, bufsz - pos,

					"bitmap1\trate_n_flags");

			pos += scnprintf(buf + pos, bufsz - pos, "\n");

				"start_idx\tbitmap\t\t\trate_n_flags\n");



		for (j = 0; j < MAX_TID_COUNT; j++) {

			pos += scnprintf(buf + pos, bufsz - pos,

						"[%d]:\t\t%u", j,

						station->tid[j].seq_number);

				pos += scnprintf(buf + pos, bufsz - pos,

						"\t%u\t\t%u\t\t%u\t\t",

				"%d:\t%#x\t%#x\t%u\t%u\t%u\t\t%#.16llx\t%#x",

				j, station->tid[j].seq_number,

				station->tid[j].agg.txq_id,

				station->tid[j].agg.frame_count,

						station->tid[j].agg.wait_for_ba);

				pos += scnprintf(buf + pos, bufsz - pos,

						"%u\t%llu\t%u",

				station->tid[j].tfds_in_queue,

				station->tid[j].agg.start_idx,

						(unsigned long long)station->tid[j].agg.bitmap,

				station->tid[j].agg.bitmap,

				station->tid[j].agg.rate_n_flags);



			if (station->tid[j].agg.wait_for_ba)

				pos += scnprintf(buf + pos, bufsz - pos,

						 " - waitforba");

			pos += scnprintf(buf + pos, bufsz - pos, "\n");

		}



		pos += scnprintf(buf + pos, bufsz - pos, "\n");

	}

	}



	ret = simple_read_from_buffer(user_buf, count, ppos, buf, pos);

	kfree(buf);

CRA Git | Maintained and supported by SUSTech CRA and CCSE