Commit da6f1da8 authored Jun 13, 2016 by Nicolas Dichtel Committed by David S. Miller Jun 14, 2016

ovs/gre: fix rtnl notifications on iface deletion



The function gretap_fb_dev_create() (only used by ovs) never calls
rtnl_configure_link(). The consequence is that dev->rtnl_link_state is
never set to RTNL_LINK_INITIALIZED.
During the deletion phase, the function rollback_registered_many() sends
a RTM_DELLINK only if dev->rtnl_link_state is set to RTNL_LINK_INITIALIZED.

Fixes: b2acd1dc ("openvswitch: Use regular GRE net_device instead of vport")
CC: Thomas Graf <tgraf@suug.ch>
CC: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cf5da330

net/ipv4/ip_gre.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1149,6 +1149,10 @@ struct net_device gretap_fb_dev_create(struct net net, const char *name,
		if (err)
		goto out;

		err = rtnl_configure_link(dev, NULL);
		if (err < 0)
		goto out;

		return dev;
		out:
		ip_tunnel_dellink(dev, &list_kill);

Admin message