Commit da629cf1 authored Jan 05, 2016 by Helmut Schaa Committed by Johannes Berg Jan 14, 2016

mac80211: Don't buffer non-bufferable MMPDUs



Non-bufferable MMPDUs are sent out to STAs even while in PS mode
(for example probe responses). Applying filtered frame handling for
these doesn't seem to make much sense and will only create more
air utilization when the STA wakes up. Hence, apply filtered frame
handling only for bufferable MMPDUs.

Discovered while testing an old VOIP phone that started probing
for APs while in PS mode. The mac80211/ath9k AP where the STA is
associated would reply with a probe response but the phone sometimes
moved to a new channel already and couldn't ack the probe response
anymore. In that case mac80211 applied filtered frame handling
for the un-acked probe response.

Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 2bc533bd

net/mac80211/status.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -51,6 +51,11 @@ static void ieee80211_handle_filtered_frame(struct ieee80211_local *local,
		struct ieee80211_hdr hdr = (void )skb->data;
		int ac;

		if (info->flags & IEEE80211_TX_CTL_NO_PS_BUFFER) {
		ieee80211_free_txskb(&local->hw, skb);
		return;
		}

		/*
		* This skb 'survived' a round-trip through the driver, and
		* hopefully the driver didn't mangle it too badly. However,

Admin message