Commit da3f28da authored Jun 19, 2020 by Bodo Stroesser Committed by Martin K. Petersen Jun 19, 2020

scsi: target: tcmu: Remove unnecessary bit TCMU_CMD_BIT_INFLIGHT

Since commit 61fb2482 ("scsi: target: tcmu: Userspace must not complete
queued commands") tcmu_cmd bit TCMU_CMD_BIT_INFLIGHT is set but never
checked.  So we can remove it safely.

[mkp: fixed Mike's email address]

Link: https://lore.kernel.org/r/20200619173806.5016-1-bstroesser@ts.fujitsu.com


Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
Acked-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 393403ef

drivers/target/target_core_user.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -181,7 +181,6 @@ struct tcmu_cmd {
		unsigned long deadline;

		#define TCMU_CMD_BIT_EXPIRED 0
		#define TCMU_CMD_BIT_INFLIGHT 1
		unsigned long flags;
		};
		/*
		@@ -1078,7 +1077,6 @@ static int queue_cmd_ring(struct tcmu_cmd tcmu_cmd, sense_reason_t scsi_err)
		tcmu_flush_dcache_range(mb, sizeof(*mb));

		list_add_tail(&tcmu_cmd->queue_entry, &udev->inflight_queue);
		set_bit(TCMU_CMD_BIT_INFLIGHT, &tcmu_cmd->flags);

		/* TODO: only if FLUSH and FUA? */
		uio_event_notify(&udev->uio_info);

Admin message