Commit da3a53a7 authored Mar 16, 2019 by Changbin Du Committed by Arnaldo Carvalho de Melo Mar 19, 2019

perf maps: Purge all maps from the 'names' tree



Add function __maps__purge_names() to purge all maps from the names
tree.  We need to cleanup the names tree in maps__exit().

Detected with gcc's ASan.

Signed-off-by: Changbin Du <changbin.du@gmail.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Eric Saint-Etienne <eric.saint.etienne@oracle.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Fixes: 1e628569 ("perf symbols: Fix slowness due to -ffunction-section")
Link: http://lkml.kernel.org/r/20190316080556.3075-12-changbin.du@gmail.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent b49265e0

tools/perf/util/map.c

+15 −0

Original line number	Diff line number	Diff line
		@@ -577,10 +577,25 @@ static void __maps__purge(struct maps *maps)
		}
		}

		static void __maps__purge_names(struct maps *maps)
		{
		struct rb_root *root = &maps->names;
		struct rb_node *next = rb_first(root);

		while (next) {
		struct map *pos = rb_entry(next, struct map, rb_node_name);

		next = rb_next(&pos->rb_node_name);
		rb_erase_init(&pos->rb_node_name, root);
		map__put(pos);
		}
		}

		static void maps__exit(struct maps *maps)
		{
		down_write(&maps->lock);
		__maps__purge(maps);
		__maps__purge_names(maps);
		up_write(&maps->lock);
		}

Admin message