Commit da39b5ee authored May 13, 2020 by Andrey Konovalov Committed by Felipe Balbi May 14, 2020

usb: raw-gadget: fix null-ptr-deref when reenabling endpoints

Currently we preassign gadget endpoints to raw-gadget endpoints during
initialization. Fix resetting this assignment in raw_ioctl_ep_disable(),
otherwise we will get null-ptr-derefs when an endpoint is reenabled.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>

parent 61d2658d

drivers/usb/gadget/legacy/raw_gadget.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -867,7 +867,6 @@ static int raw_ioctl_ep_disable(struct raw_dev *dev, unsigned long value)
		spin_lock_irqsave(&dev->lock, flags);
		usb_ep_free_request(dev->eps[i].ep, dev->eps[i].req);
		kfree(dev->eps[i].ep->desc);
		dev->eps[i].ep = NULL;
		dev->eps[i].state = STATE_EP_DISABLED;
		dev->eps[i].disabling = false;

Admin message