Commit da2ef1e5 authored Nov 09, 2016 by Daode Huang Committed by David S. Miller Nov 10, 2016

net: hns: bug fix about restart auto-negotiation



When set auto-negotiation off and duplex half, if run "ethtool -r ethX"
on port with phy, then the port will be failed to work. It should
forbid to start auto-negotiation when auto-negotiate is off. This
patch add the limited condition.

Reported-by: Jinchuang Tian <tianjinchuang1@huawei.com>
Signed-off-by: Daode Huang <huangdaode@hisilicon.com>
Reviewed-by: Yisen Zhuang <yisen.zhuang@huawei.com>
Reviewed-by: lipeng <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2e7c8057

drivers/net/ethernet/hisilicon/hns/hns_ethtool.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1178,7 +1178,8 @@ static int hns_nic_nway_reset(struct net_device *netdev)
	struct phy_device *phy = netdev->phydev;		struct phy_device *phy = netdev->phydev;

	if (netif_running(netdev)) {		if (netif_running(netdev)) {
	if (phy)		/* if autoneg is disabled, don't restart auto-negotiation */
			if (phy && phy->autoneg == AUTONEG_ENABLE)
	ret = genphy_restart_aneg(phy);		ret = genphy_restart_aneg(phy);
	}		}

Admin message