[ARM] pxafb: fix building issue of incorrect reference (da2c3f0e) · Commits · 戴 / test

Commit " drivers/video: Move dereference after NULL test" introduced a build error of "fbi->dev->platform_data->smart_update" being unknown type to the compiler, fix this by removing the unnecessary test of 'fbi'. Cc: Julia Lawall <julia@diku.dk> Signed-off-by:

Eric Miao <eric.y.miao@gmail.com>

drivers/video/pxafb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1221,9 +1221,9 @@ static void setup_smart_timing(struct pxafb_info *fbi,
		static int pxafb_smart_thread(void *arg)
		{
		struct pxafb_info *fbi = arg;
		struct pxafb_mach_info *inf;
		struct pxafb_mach_info *inf = fbi->dev->platform_data;

		if (!fbi \|\| !fbi->dev->platform_data->smart_update) {
		if (!inf->smart_update) {
		pr_err("%s: not properly initialized, thread terminated\n",
		__func__);
		return -EINVAL;

Admin message