Commit d9ecd1f7 authored Jul 08, 2019 by Jacob Keller Committed by Jeff Kirsher Aug 04, 2019

fm10k: remove unnecessary variable initializer



The err variable in the fm10k_tlv_attr_parse function is initialized
with zero. However, the function never reads err without first assigning
it from a function call. Remove this unnecessary initialization.

This was detected by cppcheck and resolves the following warning
produced by that tool:

[fm10k_tlv.c:498]: (style) Variable 'err' is assigned a value that is
never used.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 9e8fb252

drivers/net/ethernet/intel/fm10k/fm10k_tlv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -472,7 +472,7 @@ static s32 fm10k_tlv_attr_parse(u32 attr, u32 *results,
		const struct fm10k_tlv_attr *tlv_attr)
		{
		u32 i, attr_id, offset = 0;
		s32 err = 0;
		s32 err;
		u16 len;

		/* verify pointers are not NULL */

Admin message